add the login function #29
Conversation
|
May be this project need use poetry to replace requirements.txt+setup.py |
sqladmin/application.py
Outdated
| ) -> None: | ||
| self.app = app | ||
| self.engine = engine | ||
| self.base_url = base_url | ||
| self._model_admins: List[Type["ModelAdmin"]] = [] | ||
|
|
||
| self.templates = Jinja2Templates("templates") | ||
| self.templates.env.add_extension("jinja2.ext.i18n") | ||
| if language: | ||
| translation = gettext.translation( |
There was a problem hiding this comment.
I'd rather do this in a separate changes to keep small PR and make review easier. What do you think?
There was a problem hiding this comment.
I'll pay attention next time.
If you think I submit too many contents this time, I can submit them separately.
There was a problem hiding this comment.
that would be great. If you could focus this PR on the login functionality and do other PRs for translation and other things I'd really appreciate that.
PRs are always appreciated :)
sqladmin/application.py
Outdated
| @@ -204,7 +258,12 @@ async def list(self, request: Request) -> Response: | |||
|
|
|||
| async def detail(self, request: Request) -> Response: | |||
| """Detail route.""" | |||
|
|
|||
| if not check_token(request): | |||
There was a problem hiding this comment.
A @login_required would be easier here.
Actually I use poetry in another project but I think this seems more reasonable. Why do you think so? |
|
I think poetry is easier and cheaper. |
|
I ran into a problem that the./script/build directive would run fine on my local, but not in CI/CD. |
I'll fix that separately in another PR. Thanks Update: I can't really fix that, it's the conf.py file you've added. |
|
I have cleared i18n code and add 'create manager' cli. |
|
This generally looks good, but to be honest I think we should probably do something like Flask-Admin does here, and leave all user management, cli and things like that out of SQLAdmin. What do you think? |
|
The Spring Festival is coming. I want to have a rest. You're right, the question of whether you need to introduce authentication and permissions really needs to be thought about. I'll get back to you over the holidays. |
|
Write |
I tried adding the login function. Including the following:
Now there has some question:
1.I don't know how to create an executable with setup.py.(I can only use poetry to create a program by
tool.poetry.scripts)2. Most of this update is from my old project.But it need deeply test.
3. Doc need update.
In new version,you need create a .env in project's root.And .env need this data(like this):
SECRET_KEY=aawinjwol;egbfnjek bnl
DATABASE_URL=sqlite:///example.db
If you want to create a manager:
bash