-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQLModel support #57
Comments
Thanks a lot for the suggestion 馃憤 |
Thank you! Looking forward to it! |
Awesome! name: str = Field(max_length=12)
age: int = Field(ge=0, le=100) We can auto-add validators( like If needed, I wish to provide some contribution to it. |
Honestly I haven't taken a deep look into it, but yeah maybe something like that will do it. What I suggest is to split that into multiple PRs, so my first attempt would be to just make it work with SQLModel because right now the field conversion fails.
That would be more than welcome, feel free to go for it 馃憤 |
Hi! Do you want to add fully support of sqlmodel? I just have done some "tweaks" to make it work in my current project, and can make a PR. By the way, if there is some requirements, I would try to help |
Hey @EZhivaikin , And yes, all sorts of contributions are welcome, please do create a PR for it 馃憤 As for other improvements, my initial goal is to support the flask-admin features, there are still some of them missing here. So what I suggest is that if you want/can help with anything first let's create an issue and then do the PRs. How does that sound? |
Sounds great, I'll try to do this all asap 馃槂 |
I've created a PR to add SQLModel support in SQLAdmin. It would be appreciated if anyone could take a look. |
Discussed in #56
Originally posted by JonasKs February 16, 2022
Hi! This looks awesome, I鈥檓 definitely going to test it out!
Since this support SQLAlchemy, will it also support SQLModel? 馃槉
As suggested by @JonasKs, I did test SQLAdmin with SQLModel but it needs a few tweaks to make it work.
I'll get to it after we have the minimum functionality like #24 done.
The text was updated successfully, but these errors were encountered: