Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with the exports property in the package #41

Closed
aminnairi opened this issue Jun 3, 2023 · 0 comments · Fixed by #42
Closed

Issue with the exports property in the package #41

aminnairi opened this issue Jun 3, 2023 · 0 comments · Fixed by #42
Assignees
Labels
bug Something isn't working
Milestone

Comments

@aminnairi
Copy link
Owner

Describe the bug
This library is not usable with PNPM & Yarn when using TypeScript. Once the library installed with one of the latter, the type definition are not found, even though they are distributed in the package when installed.

To Reproduce
Steps to reproduce the behavior:

  1. Go through the quick start, only replace npm with either yarn or pnpm
  2. Open up VSCode
  3. See that the type definitions can't be found

Expected behavior
There should be no type errors when using this library with TypeScript.

Screenshots
None.

Environment (please complete the following information):

  • Operating System: [e.g. Windows 10]: Linux archlinux 6.1.30-1-lts Cleaner package example #1 SMP PREEMPT_DYNAMIC Wed, 24 May 2023 17:18:57 +0000 x86_64 GNU/Linux
  • Browser [e.g. Chrome 108]: Chrome 114
  • Node [e.g. 18.0.0]: 19.0.0
  • Package Manager [e.g. NPM 8.2.9]: 8.19.2
  • Package Version [e.g. 0.1.0]: 0.6.0

Additional context
This is probably due to the exports Node.js's NPM property not being accounted properly by either yarn nor pnpm.

@aminnairi aminnairi added the bug Something isn't working label Jun 3, 2023
@aminnairi aminnairi added this to the 0.6.1 milestone Jun 3, 2023
@aminnairi aminnairi self-assigned this Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant