Collect wildcards in statements before splitting #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Statement.split
, the list of actions wasn't being deduplicated, going through wildcard matching, etc. before being split. The end result was that some of the intermediate statements were by themselves too big to be packed into a single policy. It went something like this:Oops! Since the un-cleaned-up list is typically a lot bigger than the canonicalized output, some of those child statements may be a lot larger than expected.
This fixes that and refactors just a little bit. All of the test changes are renames due to adjust for the refactoring, plus running a newer version of Black.