Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabPreview.uc.js #29

Closed
kaos-55 opened this issue Feb 11, 2022 · 9 comments
Closed

TabPreview.uc.js #29

kaos-55 opened this issue Feb 11, 2022 · 9 comments
Labels
enhancement New feature or request fixed The issue has been fixed in a newer version

Comments

@kaos-55
Copy link

kaos-55 commented Feb 11, 2022

Hi @aminomancer I recently found your repository and saw that it is possible to add some features to Firefox through javascripts (userchromejs). I am currently using the private tab script as there is no extension that provides such a feature.

Searching the web for a replacement for the tab scope extension that allows thumbnails on tabs I did not find anything similar.
Is there a possibility that a script could be written to show thumbnails on tabs? If so, could this script I found on the web be ported to work with the latest version of Firefox?

TabPreview.zip

@kaos-55 kaos-55 added the enhancement New feature or request label Feb 11, 2022
@aminomancer
Copy link
Owner

Sure, does this work for you?

@kaos-55
Copy link
Author

kaos-55 commented Feb 11, 2022

Oh thank you so much.
I have been testing the script and I have noticed that in some pages that use long titles the thumbnail shows an empty space, I upload some examples. Besides that it works well.
tabthumb
tabthumb1
tabthumb2

@aminomancer
Copy link
Owner

So what do you think it should do instead? To avoid any empty space, I either need to 1) limit the max width of the label, making it wrap onto multiple lines or just overflow and terminate in a ... ellipsis; or 2) unlimit the max height of the thumbnail, which might get out of control.

@aminomancer
Copy link
Owner

Alright I ended up letting the label wrap onto multiple lines, so try updating to v1.0.1. I also changed the aspect ratio to 16:9 fwiw

@silverwings15
Copy link

very cool idea. is there any way TST compatibility could be added like with the old extension?

@aminomancer
Copy link
Owner

very cool idea. is there any way TST compatibility could be added like with the old extension?

I don't know which extension you're talking about. I never used old Firefox extensions. But anyway, that would probably be a bit involved. Might even require rebuilding TST in a different format. Strictly speaking it is possible to use JSActors in the webext-browsers message manager group to send information from the content to the chrome window. But idk how much information will even be exposed to the child actor running in the sidebar. That is one of the reasons I made the vertical tabs pane script, so that everything would be in the chrome window, in the parent process.

@silverwings15
Copy link

oh, i meant the old Tab Scope extension from which the idea for this script was derived. i should ask about it on the TST side and see what they think. your vertical tabs pane is great, but sadly it lacks the litany of helper addons that make TST so robust in functionality

@aminomancer
Copy link
Owner

yeah there are trade-offs to everything

@kaos-55
Copy link
Author

kaos-55 commented Feb 13, 2022

Awesome, it works and looks great, it's perfect.
Once again thank you very much for your work, you managed to bring back one of the features lost in Firefox when it removed its extensions in favor of webextensions.
I think this issue can be closed.
thumb1

@aminomancer aminomancer added the fixed The issue has been fixed in a newer version label Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed The issue has been fixed in a newer version
Projects
None yet
Development

No branches or pull requests

3 participants