Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an option for not adding the default Conan remotes #148

Closed
fgallegosalido opened this issue Sep 4, 2022 · 4 comments
Closed

Adding an option for not adding the default Conan remotes #148

fgallegosalido opened this issue Sep 4, 2022 · 4 comments
Labels
Milestone

Comments

@fgallegosalido
Copy link

fgallegosalido commented Sep 4, 2022

Currently, the conan section forces the addition of both the conan-center-index and bincrafters remotes by default. Even though the comments state that we can remove remotes, I can't figure out how to do it without calling conan through add_custom_command or something like that.

The thing with adding bincrafters by default is that it sometimes complains about some env variables not defined. For that reason, and the fact that not everybody is going to use dependencies from the bincrafters remote, I propose to remove its addition and let the users decide whether they want to add it or not. Maybe a wrapper around conan_add_remote could be added to ease the job for users.

Upvote & Fund

@aminya is using Polar.sh so you can upvote and help fund this issue. The funding is received once the issue is completed & confirmed by you.

Thank you in advance for helping prioritize & fund our backlog!


Fund with Polar
@aminya aminya changed the title The bincrafters remote shouldn't be added by default Adding an option for not adding the default Conan remotes Sep 4, 2022
@aminya
Copy link
Owner

aminya commented Sep 4, 2022

The current default works for most of the users. We can add an option that skips the addition of the remotes.

@aminya aminya added the good first issue Good for newcomers label Sep 4, 2022
@fgallegosalido
Copy link
Author

fgallegosalido commented Sep 4, 2022

Something I forgot to mention is that bincrafters recipes seem to be slowing down quite a bit. This could mean that, once Conan V2 is released, many recipes can stop working all together. As the officially mantained ones are from the Conan Center Index, I would add that remote by default (maybe add an option, but most users use this remote) and just not add the bincrafters at all.

@aminya aminya added this to the v1.0.0 milestone Oct 30, 2022
@jmarrec
Copy link
Contributor

jmarrec commented Jan 5, 2023

To me the problem is really that it uses a different name that the conan default, so basically it renames conancenter to cci for 99% of users.

conan_add_remote(
NAME
cci
URL
https://center.conan.io
INDEX
0)

This is the conan default:

https://github.com/conan-io/conan/blob/c3fc425871149b12a1d12153bed90a06a3d20132/conans/client/cache/remote_registry.py#L14

CONAN_CENTER_REMOTE_NAME = "conancenter"

@aminya
Copy link
Owner

aminya commented Jan 9, 2023

Fixed in #185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants