Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning instead of error if clang-tidy and cppcheck are not installed? #30

Closed
aminya opened this issue Nov 24, 2021 · 0 comments · Fixed by #31
Closed

Warning instead of error if clang-tidy and cppcheck are not installed? #30

aminya opened this issue Nov 24, 2021 · 0 comments · Fixed by #31
Labels
enhancement New feature or request question Further information is requested

Comments

@aminya
Copy link
Owner

aminya commented Nov 24, 2021

I think we should enable clang-tidy and cppcheck by default, but instead of throwing errors if they are missing, we can give warnings.

The use case is that I want to enable clang-tidy and cppcheck on my own machine because I am sure they are installed, but I want to also allow the users to build the project even if they do not have these.

We can still allow this to error out if WARNING_AS_ERRORS is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant