fix: add npm downloads total #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlike Mike Reagent <olsten.larck@gmail.com>
|
Since this Pull Request originated from a forked repository, Now cannot deploy it as there are potential security risks. If you are a collaborator on this repository, consider making this Pull Request from a branch on the same repository instead of a fork. |
Signed-off-by: Charlike Mike Reagent <olsten.larck@gmail.com>
|
Glad to have you here! And thanks! |
|
btw, downloads/day seems bugged? it shows |
|
That's before my merged updates. |
|
I noticed that, while the api did returns 0, I have no idea & leave that bug there. Wait a sec, there's a https://api.npmjs.org/downloads/point/2018-07-19/express 😄 |
|
Ahha, you already done that fix 😆 |
|
Oh cool. Didn't noticed that endpoint. Will PR to change to it instead of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #13
Huh. That was fast and fun! 🎉
That's a service, that's a library, hooorey!
Shields sucks, for years. I started such service with koa back in 2014 if i remember correctly. But never got the time to finish it "officially" and release it.
It was times that there was mostly ES5 and no Babel or such :D
It was times, that Shields "server.js" was around 2000-3000 lines of code...
and HELL they still add to that file?! Currently it is 7900+, wtf.