Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS Review Comments - Reviewer 1 #2

Open
amkrajewski opened this issue May 10, 2024 · 0 comments
Open

JOSS Review Comments - Reviewer 1 #2

amkrajewski opened this issue May 10, 2024 · 0 comments
Assignees

Comments

@amkrajewski
Copy link
Owner

Below are initial (itemized) JOSS review comments from @Henrium. I will progressively work on addressing them one-by-one here.

  1. I have tested in both GitHub Codespaces and Linux, the package is easy to install and works as claimed.

  2. Summary: I suggest the following to make it more accessible to "diverse, non-specialist audience": (1) introduce the background first, then what nimCSO is and what it does; (2) elaborate on the purpose and challenges.

  3. State of field: What are some other approaches to compositional space optimization; are there relevant software? References should be added if applicable. It's not necessary to compare with them, but good to make the paper informative.

  4. In quickstart.ipynb: the routine mostCommon is clear at first, but got confusing when it comes to "removing elements". What's the optimization objective of removing elements?

  5. The "Algorithm-Based Search" method relies on an assumption, "elements present in already expanded ...", is it supported by any rationale, experiments, prior studies, etc.?

  6. I didn't find "community guidelines", though it doesn't seem necessary here. Consider adding one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant