Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the problem of mean bag length #5

Closed
connorchen opened this issue Dec 6, 2018 · 3 comments
Closed

the problem of mean bag length #5

connorchen opened this issue Dec 6, 2018 · 3 comments

Comments

@connorchen
Copy link

connorchen commented Dec 6, 2018

hi,
you said 'Mean bag length parameter shouldn't be much larger than 10', however the paper Attention-based Deep Multiple Instance Learning says that 'In the experiments we use different numbers of the mean
bag size, namely, 10 , 50 and 100'. How to explain this contradiction, in my experiments no matter what the variance is, the proportion will be unbalanced as long as the mean bag length more than 10.

@max-ilse
Copy link
Collaborator

max-ilse commented Dec 22, 2018

Hi,

For simplicity the data loader in this repo is not the one that was used in the original experiments. If you write me an email to m.ilse@uva.nl I am happy to send you the original data loader.

@rjbruin
Copy link

rjbruin commented Feb 5, 2019

I'm also concerned about this. I've reproduced your code and I am able to reproduce your results for mean bag size 10, but for higher bag sizes I'm seeing nearly exclusively positive ground truth bags (as to be expected when sampling for n > 10 instances and a chance of 1/10 to draw a positive sample) leading to the model overfitting on solely positive predictions.

Can you share the original data loader? I will send you an email as well, but it seems to me it would also be a valuable addition to this repository.

@max-ilse
Copy link
Collaborator

Hey everybody,

I just added the data loader. It is not as clean as the rest of the code but is doing the job.

Best,
Max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants