Methods Missing from Type Definitions

[SaltedBlowfish]

addHasReachedTopListener and removeHasReachedTopListener are missing from the TypeScript definitions causing an error when importing from react-native-actions-sheet.

Reproduction:

1. Start TypeScript React Native project
2. Import the required functions:

import ActionSheet, {
  addHasReachedTopListener,
  removeHasReachedTopListener,
} from 'react-native-actions-sheet';

Output:

Module '"react-native-actions-sheet"' has no exported member 'addHasReachedTopListener'. Did you mean to use 'import addHasReachedTopListener from "react-native-actions-sheet"' instead?
Module '"react-native-actions-sheet"' has no exported member 'removeHasReachedTopListener'. Did you mean to use 'import removeHasReachedTopListener from "react-native-actions-sheet"' instead?

[ammarahm-ed]

I will add the defs! Thanks for reporting

[naderalfakesh]

Currently I am using until we get the defs in the new release:
Thanks in advanced

useEffect(() => {
    DeviceEventEmitter.addListener('hasReachedTop', callback);
    return () => {
      DeviceEventEmitter.removeListener('hasReachedTop', callback);
    };
  }, []);

[ammarahm-ed]

fixed in v0.4.4
There is also a new prop added that you can use:

<ActionSheet
onPositionChanged={(onReachedTop)=>{}}
/>

[efstathiosntonas]

@ammarahm-ed why onPositionChanged is a mandatory prop? I think it should be optional

[ammarahm-ed]

@ammarahm-ed why onPositionChanged is a mandatory prop? I think it should be optional

Yeah, I think I forgot to add "?" in type defs

[ammarahm-ed]

@ammarahm-ed why onPositionChanged is a mandatory prop? I think it should be optional

Published new version with the fix.

[efstathiosntonas]

Thanks for the quick fix!! Keep up the great work!