Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite fails on windows #64

Closed
ammaraskar opened this issue Jul 16, 2017 · 1 comment
Closed

Test suite fails on windows #64

ammaraskar opened this issue Jul 16, 2017 · 1 comment
Assignees

Comments

@ammaraskar
Copy link
Owner

Haven't been on a windows machine in a while but this is what happens running the test suite on it, I'm assuming it has to do with how getsockname is implemented on windows but I'll look into it.

Traceback (most recent call last):
  File "C:\Users\ammar\workspace\pyCraft\tests\test_connection.py", line 62, in _test_connect
    self._test_connect_client(client, cond)
  File "C:\Users\ammar\workspace\pyCraft\tests\test_connection.py", line 83, in _test_connect_client
    client.connect()
  File "C:\Users\ammar\workspace\pyCraft\minecraft\networking\connection.py", line 245, in connect
    self._connect()
  File "C:\Users\ammar\workspace\pyCraft\minecraft\networking\connection.py", line 275, in _connect
    self.socket.connect((self.options.address, self.options.port))
OSError: [WinError 10049] The requested address is not valid in its context
@ammaraskar ammaraskar self-assigned this Jul 16, 2017
@ammaraskar
Copy link
Owner Author

Looks like the relevant bit is that connecting to 0.0.0.0 is not possible on windows.

joodicator pushed a commit that referenced this issue May 18, 2018
The bound address is 0.0.0.0 which usually implies all
available interfaces, which makes sense when listening
for something. However, when connecting to an address,
a specific address needs to be targeted. Hopefully, any
properly configured computer should have `localhost`
pointing to its loopback interface. Fixes #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant