Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern - Full or 33-33-33 - 3 X CTA (used on get involved) #180

Closed
Tracked by #120
AmnestyAM opened this issue May 3, 2024 · 11 comments
Closed
Tracked by #120

Pattern - Full or 33-33-33 - 3 X CTA (used on get involved) #180

AmnestyAM opened this issue May 3, 2024 · 11 comments
Assignees
Labels
UAT approved This passed User Acceptance Testing

Comments

@AmnestyAM
Copy link

AmnestyAM commented May 3, 2024

https://wordpresstheme.amnesty.org/patterns-get-involved/
image

@AmnestyAM
Copy link
Author

I might re work this just to be the 3 boxes

@Gentyspun
Copy link
Contributor

Quick question @AmnestyAM

In the example above, are you wanting the social block (Follow us on...) including in the pattern as well? or just the 3 column links with icons stuff?

@AmnestyAM
Copy link
Author

I was kind of on the fence, I feel the 3 columns might be a more useful and reusable pattern so I am leaning that way. Any thoughts @SophieAmnesty ?

@AmnestyAM
Copy link
Author

@Gentyspun looks like you did the PR already so don't mind living with either

@Gentyspun
Copy link
Contributor

PR Created: #200

@Gentyspun Gentyspun self-assigned this May 14, 2024
@AmnestyAM
Copy link
Author

I was able to add this
image

But it required me adding padding to the block, to stop the text touching the black border,

@AmnestyAM
Copy link
Author

should we add the padding on the P in the pattern?

@AmnestyAM AmnestyAM added the UAT feedback This failed User Acceptance Testing label Jun 4, 2024
@jaymcp jaymcp added UAT required This requires User Acceptance Testing and removed UAT feedback This failed User Acceptance Testing labels Jun 25, 2024
@AmnestyAM
Copy link
Author

not sure what I was re testing but the text is still touching the edges of the box

Image

@AmnestyAM AmnestyAM added UAT feedback This failed User Acceptance Testing and removed UAT required This requires User Acceptance Testing labels Jun 27, 2024
@jaymcp
Copy link
Contributor

jaymcp commented Jun 27, 2024

Apologies, I may have inadvertently moved this into UAT as part of the board cleanup work I did in preparation for the release.

@Gentyspun
Copy link
Contributor

PR Created: #258

@jaymcp jaymcp added UAT required This requires User Acceptance Testing and removed UAT feedback This failed User Acceptance Testing labels Jul 2, 2024
@AmnestyAM
Copy link
Author

LGTM

Image

@AmnestyAM AmnestyAM added UAT approved This passed User Acceptance Testing and removed UAT required This requires User Acceptance Testing labels Jul 2, 2024
@jaymcp jaymcp closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UAT approved This passed User Acceptance Testing
Projects
Status: Released to PRD
Development

No branches or pull requests

3 participants