Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern - Social Share #201

Closed
Tracked by #120
AmnestyAM opened this issue May 14, 2024 Discussed in #199 · 2 comments
Closed
Tracked by #120

Pattern - Social Share #201

AmnestyAM opened this issue May 14, 2024 Discussed in #199 · 2 comments
Assignees
Labels
UAT approved This passed User Acceptance Testing

Comments

@AmnestyAM
Copy link

Discussed in #199

Originally posted by jaymcp May 13, 2024
The existing Social Share block pattern default content uses Amnesty's social links, and a (now removed) YouTube video embed.
Now that the theme is open source, we should probably either remove this pattern from the theme, or update the default content to something generic.

Possibly worth addressing alongside #120?

@jaymcp
Copy link
Contributor

jaymcp commented May 14, 2024

PRs created to
a) remove the pattern from the theme, and
b) to add support for patterns to the branding plugin, and introduce the pattern there.

@jaymcp jaymcp self-assigned this May 14, 2024
@jaymcp jaymcp changed the title Block Patterns - Social Share Pattern - Social Share May 14, 2024
@AmnestyAM
Copy link
Author

@AmnestyAM AmnestyAM added the UAT approved This passed User Acceptance Testing label Jun 5, 2024
@jaymcp jaymcp closed this as completed Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UAT approved This passed User Acceptance Testing
Projects
Status: Released to PRD
Development

No branches or pull requests

2 participants