Skip to content
This repository has been archived by the owner on Jun 24, 2023. It is now read-only.

Plan for Bootstrap 3 ? #33

Closed
Ryuja opened this issue Aug 2, 2013 · 13 comments
Closed

Plan for Bootstrap 3 ? #33

Ryuja opened this issue Aug 2, 2013 · 13 comments

Comments

@Ryuja
Copy link

Ryuja commented Aug 2, 2013

With bootstrap 3, bootstrap-application-wizard no longer works.
Do you plan to adapt it to this new version ?

@amoffat
Copy link
Owner

amoffat commented Sep 2, 2013

Hi @Ryuja, I will not be porting the wizard to bootstrap 3. Are you interested in adding this functionality?

@mattjohnsonpint
Copy link

@Ryuja - If you (or anyone else) are planning a fork for Bootstrap 3, please let us know here. Thanks.

@elwadi
Copy link

elwadi commented Oct 7, 2013

OrcaSystems@a64498b

@glynjackson
Copy link

@elwadi nice! Thanks

@Untit1ed
Copy link

There should definitely be support for bootstrap 3

@amoffat
Copy link
Owner

amoffat commented Oct 26, 2013

@Untit1ed I will merge PRs adding this support.

@absentdream
Copy link

to get close button to show I had to add line 582

if (this.args.showClose) { this.closeButton.show(); }

many thanks
calvin

@ghost
Copy link

ghost commented Nov 29, 2013

@amoffat Do you know specifically what might cause your code to not work with BS3? And if not are there any hints you can share? Trying to use this for a project at work, but I don't want to lose too much time reading source code ;) thanks

@amoffat
Copy link
Owner

amoffat commented Nov 29, 2013

@DBSalvia Reading source code is the only way it will happen. I have not tried the wizard with bootstrap 3, and from what I understand bootstrap 3 was completely re-architected.

@amoffat
Copy link
Owner

amoffat commented Dec 4, 2013

There exists now a bootstrap-3 branch for development of bootstrap 3. Thanks to @gjrtimmer for this. Those of you interested in seeing this happen on bootstrap 3 could take some time to test out the demo.html of that branch and create issues for any problems you see, or features that are missing. Tag these issues with b3 tag.

The current plan is when bootstrap-3 branch is done, it will be come the new master, and what's on master now will live as a bootstrap-2 branch.

@gjrtimmer
Copy link
Collaborator

bootstrap-3 branch is ready for the switch.

@ghost
Copy link

ghost commented Dec 13, 2013

👍

@amoffat
Copy link
Owner

amoffat commented Dec 13, 2013

This is done and on master now. The old master lives on bootstrap-2 branch. The current master has Bootstrap 3 support. Open new issues for an problems discovered.

@gjrtimmer deserves a huge thanks from all of us, as he took on the entire Bootstrap 3 migration himself and did an excellent job. His contributions to this project have been huge 👏 👏 👏

@amoffat amoffat closed this as completed Dec 13, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants