Failed to build wheel on macOS

[rpkilby]

Just a minor issue. When installing on macOS, the wheel fails to build. This is due to the missing LICENSE file listed in the setup.cfg metadata. Most likely you just need to add the file to the MANIFEST.in.

  error: [Errno 2] No such file or directory: 'LICENSE'
  
  ----------------------------------------
  Failed building wheel for dukpy

That said, the package does install correctly as a traditional sdist. I don't fully understand the install process here, but it looks like installation attempts to build the wheel first, which fails then falls back to installing the sdist.

[webknjaz]

@amol- I can make Travis CI build OS X wheels as well. Shall I?

[webknjaz]

Also, the manifest issue could be avoided if dist relied on setuptools' VCS integrations (effectively including all files tracked by Git).

[rpkilby]

Does that allow you to exclude package cruft (eg, appveyor.yml and .travis.yml) as well as tests?

[webknjaz]

It does, but @amol- didn't support idea of having setup_requires: https://github.com/amol-/dukpy/issues/15#issuecomment-315634909

Although, I'm not sure why I'd want to exclude (python) tests.

[rpkilby]

Although, I'm not sure why I'd want to exclude (python) tests.

Mainly just that they're unnecessary? They're included with the distribution, but not installed.

It doesn't matter to me too much - was just curious.

[webknjaz]

That's questionable. Normally when you ship some distribution you want to provide ppl with a way to run tests. Even better: lots of package managers have built-in feature of running tests before installing things.

[rpkilby]

I'm not arguing whether or not the practice is good. My point was that even if you include the tests in the distribution, the files are not installed, and as a result, are not importable/runnable. You would need to manually unpack the sdist/wheel to grab the test files and then recreate the test environment.

[amol-]

Version 0.2.1 ( https://github.com/amol-/dukpy/releases/tag/0.2.1 ) is releasing with a fix that allows building wheels from source distribution.