Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Do list: interactive list #4

Merged
merged 1 commit into from Oct 1, 2022
Merged

To Do list: interactive list #4

merged 1 commit into from Oct 1, 2022

Conversation

amon-cofie
Copy link
Owner

In this "To-Do-List" project, I created the basic structure of a single page application with HTML, CSS and javascript, using the webpack bundler to bundle all the source files in the "src" folder into the "dist" folder for distribution. I did the following things:

  • Installed the webpack bundler
  • Generated the index.html file in the dist folder from the source folder using an html plugin
  • Wrote functions function to iterate over the tasks array and populate an HTML list item element for each task.
  • Wrote functions to add a task and remove the task
  • Added functions to give the page some interactivity
  • Added CSS styling for the to do list application.

Copy link

@franclobo franclobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amon-cofie,

STATUS: APPROVED 😃

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • No linter errors ✔️
  • Correct Github flow ✔️
  • Descriptive PR ✔️
  • Professional README file ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@amon-cofie amon-cofie merged commit 83dfb78 into main Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants