Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I upload the contents of a folder with pre-built assets? #22

Closed
NullVoxPopuli opened this issue Feb 11, 2020 · 4 comments
Closed

Can I upload the contents of a folder with pre-built assets? #22

NullVoxPopuli opened this issue Feb 11, 2020 · 4 comments
Assignees
Labels
Type: Question Further information is requested

Comments

@NullVoxPopuli
Copy link

I'd like to manage the build for my app in GH actions. Is this possible with the now action?

@amondnet amondnet self-assigned this Feb 11, 2020
@amondnet amondnet added the Type: Question Further information is requested label Feb 11, 2020
@amondnet
Copy link
Owner

amondnet commented Feb 11, 2020

Yes it is possible.
example(angular):

name: deploy
on:
  push:
    branches:
      - master
jobs:
  build:
    name: build and deploy
    runs-on: ubuntu-latest
    needs: prepare
    steps:
    - uses: actions/checkout@v2
    - name: Use Node.js 12.10
      uses: actions/setup-node@v1
      with:
        node-version: 12.10
    - name: npm install, build
      run: |
        npm install
        npx ng build --prod
    - uses: amondnet/now-deployment@v1
      with:
        zeit-token: ${{ secrets.NOW_TOKEN }}
        now-args: '--prod'
        working-directory: ./dist/sample-app

@NullVoxPopuli
Copy link
Author

how would that show up in the "Checks" part of a PR? would the URL be available under the "Details" link?
also, would this work without the prod flag for now?

@amondnet
Copy link
Owner

amondnet commented Feb 11, 2020

how would that show up in the "Checks" part of a PR? would the URL be available under the "Details" link?

see #2 #11

also, would this work without the prod flag for now?

yes, https://github.com/amondnet/now-deployment/blob/master/.github/workflows/deploy.yml

@NullVoxPopuli
Copy link
Author

oooo nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants