Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneDriveFileProvider has outdate OneDrive API support #55

Closed
evilutioner opened this issue Jul 26, 2017 · 4 comments
Closed

OneDriveFileProvider has outdate OneDrive API support #55

evilutioner opened this issue Jul 26, 2017 · 4 comments
Labels

Comments

@evilutioner
Copy link
Contributor

OneDriveFileProvider currently doesn't work. The default API entry base url https://api.onedrive.com/ response error "bad request". OneDriveHelper.swift has issues with url parsing. New OneDrive API operates with 'root:' instead of 'root'

@amosavian amosavian added the bug label Jul 29, 2017
@amosavian
Copy link
Owner

amosavian commented Jul 31, 2017

Please check latest commit @evilutioner

@evilutioner
Copy link
Contributor Author

It doesn't work, this api cannot load root folder at least. I discovered additional issues:

  1. multiple percent encoding for path folder with spaces changed this " " to %25%25%25%20. Percent encoding operation should be only once per path string.
  2. IOS API - URL(string: rpath, relativeTo: driveURL) returns nil with base url if it contains symbol ":" in path (in onedrive case "root:")

@evilutioner
Copy link
Contributor Author

evilutioner commented Aug 1, 2017

Created pull request: #57

@amosavian
Copy link
Owner

Fixed by pull request #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants