Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

40 use json schema to validate endpoint structure #48

Merged
merged 12 commits into from
Jun 7, 2022
Merged

40 use json schema to validate endpoint structure #48

merged 12 commits into from
Jun 7, 2022

Conversation

FlinkbaumFAU
Copy link
Collaborator

No description provided.

@raghunandanarava
Copy link
Collaborator

Can we move the implementation in app.controller.ts and app.service.ts to a separate module maybe?

prebbe
prebbe approved these changes Jun 7, 2022
View reviewed changes
Copy link
Collaborator

@prebbe prebbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/app.controller.ts Outdated Show resolved Hide resolved
@prebbe
Copy link
Collaborator

prebbe commented Jun 7, 2022

@FlinkbaumFAU : Please fix the current conflicts.

@FlinkbaumFAU FlinkbaumFAU merged commit 19d9448 into main Jun 7, 2022
@prebbe prebbe linked an issue Jun 8, 2022 that may be closed by this pull request
Use JSON schema to validate endpoint structure #40
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prebbe prebbe prebbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use JSON schema to validate endpoint structure
3 participants
@FlinkbaumFAU @raghunandanarava @prebbe