Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gather art does not gather #3262

Open
PsyZeus opened this issue May 9, 2022 · 5 comments
Open

Gather art does not gather #3262

PsyZeus opened this issue May 9, 2022 · 5 comments
Labels
stale Issues not updated in over a year

Comments

@PsyZeus
Copy link

PsyZeus commented May 9, 2022 •
edited

As title says, it's back, oh man...
Changing the order doesn't work anymore.
I tried so far
art_order = "db,folder,tags,spotify,TheAudioDb,musicbrainz,lastfm"
art_order = "db,tags,folder,spotify,TheAudioDb,musicbrainz,lastfm"
art_order = "db,folder,tags"
art_order = "db,tags,folder"

and i always have the same outcome in log, no changes at all.

Seems like something is wrong with _get_plugin_tag ...no matter if i have TheAudioDb or musicbrainz in art_order i get the same error.

  • Ampache version: 5.3.3_all_php8.1.zip

Log

2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\System\Dba) -> Database connection...
2022-05-09T21:03:27+03:00 [ampache] (log.lib) -> [Error] Constant FILTER_SANITIZE_STRING is deprecated in file /var/www/html/ampachetest/src/Module/System/Session.php(757)
2022-05-09T21:03:27+03:00 [ampache] (log.lib) -> [Error] Return type of Gettext\Translations::offsetSet($index, $value) should either be compatible with ArrayObject::offsetSet(mixed $key, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in file /var/www/html/ampachetest/vendor/gettext/gettext/src/Translations.php(218)
2022-05-09T21:03:27+03:00 [ampache] (log.lib) -> [Error] substr(): Passing null to parameter #2 ($offset) of type int is deprecated in file /var/www/html/ampachetest/vendor/gettext/gettext/src/Utils/StringReader.php(31)
2022-05-09T21:03:27+03:00 [ampache] (log.lib) -> [Error] Constant FILTER_SANITIZE_STRING is deprecated in file /var/www/html/ampachetest/src/Repository/Model/User.php(1295)
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\System\Session) -> efhthr8ofurlvbpi42p6ljh3jb has been extended to Mon, 09 May 2022 22:03:27 +0300 extension length 3600
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\Application\ApplicationRunner) -> Found handler "Ampache\Module\Application\Admin\Catalog\AddToCatalogAction" for action "add_to_catalog"
2022-05-09T21:03:27+03:00 [ampache] (log.lib) -> [Error] Constant FILTER_SANITIZE_STRING is deprecated in file /var/www/html/ampachetest/src/Module/System/Core.php(127)
2022-05-09T21:03:27+03:00 [ampache] (log.lib) -> [Error] Constant FILTER_SANITIZE_STRING is deprecated in file /var/www/html/ampachetest/src/Module/System/Core.php(127)
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\System\Session) -> Session created: 55e15bcc3abe2288df91c326bc5a2c51
2022-05-09T21:03:27+03:00 [ampache] (log.lib) -> [Error] Constant FILTER_SANITIZE_STRING is deprecated in file /var/www/html/ampachetest/src/Module/System/Core.php(127)
2022-05-09T21:03:27+03:00 [ampache] (log.lib) -> [Error] Constant FILTER_SANITIZE_STRING is deprecated in file /var/www/html/ampachetest/src/Module/Application/Admin/Catalog/AbstractCatalogAction.php(71)
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\System\Core) -> Registered post form confirmation with SID 8ca13063e36d8ac138b3c51681766287 and expiration 1652123007 (3600 seconds from now)
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\System\Session) -> Writing to efhthr8ofurlvbpi42p6ljh3jb with expiration 1652123007
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\System\Dba) -> Database connection...
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\System\Dba) -> Database connection...
2022-05-09T21:03:27+03:00 [ampache] (log.lib) -> [Error] Constant FILTER_SANITIZE_STRING is deprecated in file /var/www/html/ampachetest/src/Module/System/Session.php(757)
2022-05-09T21:03:27+03:00 [ampache] (log.lib) -> [Error] Return type of Gettext\Translations::offsetSet($index, $value) should either be compatible with ArrayObject::offsetSet(mixed $key, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in file /var/www/html/ampachetest/vendor/gettext/gettext/src/Translations.php(218)
2022-05-09T21:03:27+03:00 [ampache] (log.lib) -> [Error] substr(): Passing null to parameter #2 ($offset) of type int is deprecated in file /var/www/html/ampachetest/vendor/gettext/gettext/src/Utils/StringReader.php(31)
2022-05-09T21:03:27+03:00 [ampache] (log.lib) -> [Error] Constant FILTER_SANITIZE_STRING is deprecated in file /var/www/html/ampachetest/src/Repository/Model/User.php(1295)
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\System\Session) -> efhthr8ofurlvbpi42p6ljh3jb has been extended to Mon, 09 May 2022 22:03:27 +0300 extension length 3600
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\System\Session) -> Writing to efhthr8ofurlvbpi42p6ljh3jb with expiration 1652123007
2022-05-09T21:03:27+03:00 [ampache] (log.lib) -> [Error] Constant FILTER_SANITIZE_STRING is deprecated in file /var/www/html/ampachetest/src/Module/System/Core.php(68)
2022-05-09T21:03:27+03:00 [ampache] (local.catalog) -> Reading A inside /media
2022-05-09T21:03:27+03:00 [ampache] (local.catalog) -> Memory usage: 2 MB
2022-05-09T21:03:27+03:00 [ampache] (local.catalog) -> Found song file to import: /media/e.mp3
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\Util\VaInfo) -> _get_plugin_tags: musicbrainz is not a valid metadata_order plugin
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\Util\VaInfo) -> _get_plugin_tags: theaudiodb is not a valid metadata_order plugin
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Artist) -> check artist: created {10830}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Album) -> check album: created {6617}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> update_map album: {6617}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> update_map song: {34833}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Artist) -> add_artist_map artist_id {10830} song {34833}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Album) -> add_album_map album_id {6617} song {10830}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Artist) -> add_artist_map artist_id {10830} album {6617}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Album) -> add_album_map album_id {6617} album {10830}
2022-05-09T21:03:27+03:00 [ampache] (local.catalog) -> Found song file to import: /media/e.mp3
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\Util\VaInfo) -> _get_plugin_tags: musicbrainz is not a valid metadata_order plugin
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\Util\VaInfo) -> _get_plugin_tags: theaudiodb is not a valid metadata_order plugin
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Artist) -> check artist: created {10831}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Album) -> check album: created {6618}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> update_map album: {6618}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> update_map song: {34834}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Artist) -> add_artist_map artist_id {10831} song {34834}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Album) -> add_album_map album_id {6618} song {10831}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Artist) -> add_artist_map artist_id {10831} album {6618}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Album) -> add_album_map album_id {6618} album {10831}
2022-05-09T21:03:27+03:00 [ampache] (local.catalog) -> Found song file to import: /media/s.mp3
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\Util\VaInfo) -> _get_plugin_tags: musicbrainz is not a valid metadata_order plugin
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\Util\VaInfo) -> _get_plugin_tags: theaudiodb is not a valid metadata_order plugin
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Album) -> check album: created {6619}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> update_map album: {6619}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> update_map song: {34835}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Artist) -> add_artist_map artist_id {10831} song {34835}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Album) -> add_album_map album_id {6619} song {10831}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Artist) -> add_artist_map artist_id {10831} album {6619}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Album) -> add_album_map album_id {6619} album {10831}
2022-05-09T21:03:27+03:00 [ampache] (local.catalog) -> Found song file to import: /media/t.mp3
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\Util\VaInfo) -> _get_plugin_tags: musicbrainz is not a valid metadata_order plugin
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\Util\VaInfo) -> _get_plugin_tags: theaudiodb is not a valid metadata_order plugin
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Album) -> check album: created {6620}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> update_map album: {6620}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> update_map song: {34836}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Artist) -> add_artist_map artist_id {10831} song {34836}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Album) -> add_album_map album_id {6620} song {10831}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Artist) -> add_artist_map artist_id {10831} album {6620}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Album) -> add_album_map album_id {6620} album {10831}
2022-05-09T21:03:27+03:00 [ampache] (local.catalog) -> Found song file to import: /mediax).mp3
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\Util\VaInfo) -> _get_plugin_tags: musicbrainz is not a valid metadata_order plugin
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\Util\VaInfo) -> _get_plugin_tags: theaudiodb is not a valid metadata_order plugin
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Album) -> check album: created {6621}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> update_map album: {6621}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> update_map song: {34837}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Artist) -> add_artist_map artist_id {3504} song {34837}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Album) -> add_album_map album_id {6621} song {3504}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Artist) -> add_artist_map artist_id {3504} album {6621}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Album) -> add_album_map album_id {6621} album {3504}
2022-05-09T21:03:27+03:00 [ampache] (local.catalog) -> Found song file to import: /media/i.mp3
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\Util\VaInfo) -> _get_plugin_tags: musicbrainz is not a valid metadata_order plugin
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Module\Util\VaInfo) -> _get_plugin_tags: theaudiodb is not a valid metadata_order plugin
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Artist) -> check artist: created {10832}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Album) -> check album: created {6622}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> update_map album: {6622}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> update_map song: {34838}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Artist) -> add_artist_map artist_id {10832} song {34838}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Album) -> add_album_map album_id {6622} song {10832}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Artist) -> add_artist_map artist_id {10832} album {6622}
2022-05-09T21:03:27+03:00 [ampache] (Ampache\Repository\Model\Album) -> add_album_map album_id {6622} album {10832}
2022-05-09T21:03:28+03:00 [ampache] (Ampache\Repository\Model\Album) -> update_album_counts
2022-05-09T21:03:28+03:00 [ampache] (Ampache\Repository\Model\Artist) -> update_artist_counts
2022-05-09T21:03:29+03:00 [ampache] (Ampache\Repository\Model\Artist) -> update_artist_counts
2022-05-09T21:03:30+03:00 [ampache] (Ampache\Repository\Model\Album) -> update_album_counts
2022-05-09T21:03:30+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> Run Garbage collection
2022-05-09T21:03:32+03:00 [ampache] (Ampache\Repository\Model\Artist) -> garbage_collection
2022-05-09T21:03:33+03:00 [ampache] (Ampache\Repository\AlbumRepository) -> collectGarbage
2022-05-09T21:03:37+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> Clean Artists with duplicate mbid's
2022-05-09T21:03:37+03:00 [ampache] (Ampache\Repository\Model\Artist) -> garbage_collection
2022-05-09T21:03:38+03:00 [ampache] (Ampache\Repository\AlbumRepository) -> collectGarbage
2022-05-09T21:03:38+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> Update mapping for table: artist
2022-05-09T21:03:39+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> Update mapping for table: album
2022-05-09T21:03:39+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> update_counts after catalog changes
2022-05-09T21:03:40+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> update_counts object_count table missing artist row
2022-05-09T21:03:41+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> update_counts object_count table missing album row
2022-05-09T21:03:44+03:00 [ampache] (Ampache\Repository\Model\Artist) -> update_artist_counts
2022-05-09T21:03:44+03:00 [ampache] (Ampache\Repository\Model\Album) -> update_album_counts
2022-05-09T21:03:45+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> update_counts server total counts
2022-05-09T21:03:45+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> update_counts User::update_counts()
2022-05-09T21:03:45+03:00 [ampache] (Ampache\Repository\Model\User) -> Update counts for 1
2022-05-09T21:03:45+03:00 [ampache] (Ampache\Repository\Model\User) -> Update counts for 2
2022-05-09T21:03:45+03:00 [ampache] (Ampache\Repository\Model\Catalog) -> update_counts completed
2022-05-09T21:03:47+03:00 [ampache] (Ampache\Module\System\Dba) -> Database connection...
@lusum
Copy link
Contributor

lusum commented May 10, 2022

It seems a problem with translations strings not escaped and, with some languages, they generates an error. I had the same kind of problem with another locale and a menu.

@PsyZeus
Copy link
Author

PsyZeus commented May 11, 2022

hello @lusum i changed the language to English (US), did the test again and i'm getting the exact same errors.

Also i tested further and it seems the art gather doesn't work only when you "add" new music to an existing folder, but works fine when you add a new folder from start or when from "gather art" drop down menu

So does covers insert for you just fine when you add new music?

@lusum
Copy link
Contributor

lusum commented May 11, 2022

It seems not an error, but the default behaviour now. Add is one thing, gather art, another. Yes, it is the same for me.

@PsyZeus
Copy link
Author

PsyZeus commented May 11, 2022

Thank you @lusum :)

@lachlan-00 so is this the new behavior really?! We add covers now from "gather art" instead of the auto way from "add" ?

@rhauff1
Copy link

rhauff1 commented Jun 17, 2022

@lachlan-00 so is this the new behavior really?! We add covers now from "gather art" instead of the auto way from "add" ?

This is what I am experiencing also since at least 5.3.3, have to manually click "Gather Art"

@shikasta-net shikasta-net mentioned this issue Aug 21, 2022
Open
@mitchray mitchray added the stale Issues not updated in over a year label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale Issues not updated in over a year
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lusum @mitchray @PsyZeus @rhauff1