Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple genres on a song are treated as one tag #970

Closed
JoeDat opened this issue Sep 23, 2015 · 8 comments
Closed

Multiple genres on a song are treated as one tag #970

JoeDat opened this issue Sep 23, 2015 · 8 comments

Comments

@JoeDat
Copy link

JoeDat commented Sep 23, 2015

Noticed that if songs are tagged with multiple genres, separated by a comma, the Tag Cloud treats the entry as one tag, rather than separating it out. The genre links on the titles are also treated a single genre / link.

image

@Afterster
Copy link
Member

Is additional_genre_delimiters setting configured on your ampache.cfg.php config file?

@JoeDat
Copy link
Author

JoeDat commented Sep 23, 2015

Yes it is.

; Some taggers use delimiters other than \0 for fields
; This list specifies possible delimiters additional to \0
; This setting takes a regex pattern.
; DEFAULT: // / \ | , ;
additional_genre_delimiters = "[/]{2}|[/|||,|;]"

Default settings.

Edit: I should mention that this worked as recently as last week.

Edit2: I take that back. It's working with genres delimited with a semicolon. I tag with Beets, which uses a comma. I think that's probably a common delimiter.

@JoeDat
Copy link
Author

JoeDat commented Sep 24, 2015

I've figured out the true difference. It's not recognizing multiple genres for AAC files. MP3s are fine. So, it has nothing to do with the delimiter at all. It's the file format.

@Afterster
Copy link
Member

Mhh ok thanks for the investigation. Could you make the test with getid3 directly and related demo.browse.php? Looks like another getid3 bug. Thanks.

@JoeDat
Copy link
Author

JoeDat commented Sep 24, 2015

On a test with demo.browse.php, I do get warnings for every AAC file against an artist where I have both mp3 and AAC files. I can't decipher, so unsure if it's related, but they are all similar to the following:
image

As for the file details, the fields themselves look similar. Granted, I've never run this before, so I'm not quite sure what I'm seeing. If you want to see the output, I can export and provide it privately.

Edit: Decided to post this bug on the getID3 issue tracker

@JoeDat
Copy link
Author

JoeDat commented Sep 27, 2015

I'm in the middle of rebuilding my server, but will test out as soon as I get it back up and running.

@apastuszak
Copy link

Sounds like you're reading MPs Atoms instead of ID3 tags.

Sent from my iPhone

On Sep 24, 2015, at 4:09 PM, JoeDat notifications@github.com wrote:

On a test with demo.browse.php, I do get warnings for every AAC file against an artist where I have both mp3 and AAC files. I can't decipher, so unsure if it's related, but they are all similar to the following:

As for the file details, the fields themselves look similar. Granted, I've never run this before, so I'm not quite sure what I'm seeing. If you want to see the output, I can export and provide it privately.


Reply to this email directly or view it on GitHub.

@Afterster
Copy link
Member

Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants