Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACES to ADX transform #113

Open
scottdyer opened this issue Jan 29, 2020 · 1 comment
Open

ACES to ADX transform #113

scottdyer opened this issue Jan 29, 2020 · 1 comment

Comments

@scottdyer
Copy link
Contributor

ACES to ADX transform should be examined for possible updates as suggested in this ACES Central post

There is also a clamp in the ADX transforms (not new to 1.2):

lines around 71 in ACEScsc.ADX10_to_ACES.ctl and ACEScsc.ADX16_to_ACES.ctl

float logE[3];
if ( cid[0] <= 0.6) logE[0] = interpolate1D( LUT_1D, cid[0]);
if ( cid[1] <= 0.6) logE[1] = interpolate1D( LUT_1D, cid[1]);
if ( cid[2] <= 0.6) logE[2] = interpolate1D( LUT_1D, cid[2]);

interpolate1D is defined to clamp outside the range and so there should probably be linear extrapolation added for the lower portion of values so that values below ‘95’ (-0.19) don’t get clamped during conversion. similar to how this values above 0.6 are handled.

There are potential issues with the following pow( 10 , logE[*] ) calls, but that is a more involved discussion relating to noise, that doesn’t have as obvious a potential fix.

@KevinJW
Copy link

KevinJW commented Sep 11, 2020

Interactive demo ... https://www.desmos.com/calculator/hdiujynasa

There was also a suggestion to formulate the table as an exponential function, but I haven't fitted that yet,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants