Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from 1.4.2 to 1.4.3 causes jasmine tests to fail #56

Closed
sansthesis opened this issue Mar 26, 2015 · 3 comments
Closed

Upgrade from 1.4.2 to 1.4.3 causes jasmine tests to fail #56

sansthesis opened this issue Mar 26, 2015 · 3 comments
Assignees

Comments

@sansthesis
Copy link

I'm going to try to get a test case this weekend, but I don't know if I will be able to reproduce the environment.

My karma/jasmine unit tests pass with ampersand-collection 1.4.2 but time out 100% of the time when using 1.4.3. I think that the reindex code is hitting an infinite loop or is causing too many cascading operations.

@bear
Copy link
Contributor

bear commented Mar 26, 2015

@lukekarrys can you look at this when you get a chance - the merge for 1.4.3 shows only a single PR since 1.4.2

@lukekarrys
Copy link
Contributor

@JasonRose I will look into this also. Thanks for pointing us the in right direction with the infinite loop + cascading operations stuff. Both those things would make sense with how the new index code works I think.

@lukekarrys lukekarrys self-assigned this Mar 26, 2015
latentflip added a commit that referenced this issue Mar 26, 2015
Fix regression introduced by 1.4.3, fixes #56
@latentflip
Copy link
Contributor

Fixed in 1.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants