Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

success handlers dont get access to the actual http response #49

Open
yocontra opened this issue May 26, 2015 · 0 comments
Open

success handlers dont get access to the actual http response #49

yocontra opened this issue May 26, 2015 · 0 comments

Comments

@yocontra
Copy link

https://github.com/AmpersandJS/ampersand-model/blob/master/ampersand-model.js#L52

The resp object is the JSON.parse(body) output, not the actual HTTP request. The success and error functions are inconsistent with one another, the arguments are in different orders and even though they are called the same arg names the data is totally different. Not sure what the thought process was behind how these were arranged but I think it would make sense to normalize them and make them work the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant