Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix student prototype that is there for the image caching #355

Closed
FranSlot opened this issue Feb 5, 2024 · 0 comments · Fixed by #366
Closed

Fix student prototype that is there for the image caching #355

FranSlot opened this issue Feb 5, 2024 · 0 comments · Fixed by #366

Comments

@FranSlot
Copy link
Contributor

FranSlot commented Feb 5, 2024

Bug:
To increase load times for student containers we have a container pull the student prototype image into the cluster. This container runs without arguments. It then loads the non-existent arguments into an ADL script and passes an empty script to the ampersand compiler. The compiler throws an exception and the pod would crash. Because the deployment expects there to be at the minimum one pod, it tries to restart the crashed pod. This process would continue ad infinitum, albeit with increasing time between restarts.

Solution:
To prevent the pod from crashing we check whether there are any arguments when running the start-up script. If none are given, the pod will sleep.

@lucsomers101 lucsomers101 self-assigned this Mar 5, 2024
@lucsomers101 lucsomers101 removed their assignment Mar 18, 2024
@FranSlot FranSlot reopened this Mar 28, 2024
@FranSlot FranSlot self-assigned this Apr 4, 2024
FranSlot added a commit that referenced this issue Apr 5, 2024
@FranSlot FranSlot linked a pull request Apr 5, 2024 that will close this issue
FranSlot added a commit that referenced this issue Apr 5, 2024
…otype-that-is-there-for-the-image-caching

#355: Refactor and fix crash loop.
stefjoosten added a commit that referenced this issue Jul 15, 2024
…d-labels

* commit 'b0f8e06b995393d1b67037ac60c5b8d29c898c59':
  #372 Removed unnecessary execution permission grant
  #372 Refactored student prototype startup script
  #355: Refactor and fix crash loop.
  #356: Added explanation why we sanitise.
  #356: Forgot to add the prefix.
  #356: Added username sanitation.
  #361 added default prefix to username to prevent errors when only using numbers
  Fixed typo
  Fixes for deployment issues with prototype (newlines and chmod) documented in deployment-guide.md
  Update ExecEngineFunctions.php
  #354: Reverted imagepullpolicy
  #354: Fixed the getImageCommand
  added getimagecommand
  Added image pull policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants