Proselint doesn't work on readonly files

[viccuad]

On command_line.py:192

            f = click.open_file(fp, 'r+', encoding="utf-8")

We are opening files to be linted with 'r+', which opens the file for both reading and writing (instead of 'r' which opens as read only).

This may not be needed, and breaks proselint for some files such as demo.md (therefore it breaks proselint --demo) when installed with a distribution package manager.

I've discovered this because of the Debian proselint package I mantain has that demo.md, and I have resorted on patching it temporarily to make it open files as readonly. Please, notify me if proselint intends to modify files in the future, and we need to find another solution.

[suchow]

Thanks. We don't intend for Proselint to modify files. At some point, perhaps, it would interesting to create an autoproselint linter in analogy to autopep8, but that's a different project. I'll make this change now.

[suchow]

Hm. What version of Proselint are you looking at? On master, the line you specified already uses r:

https://github.com/amperser/proselint/blob/master/proselint/command_line.py#L115

It seems this improvement was made by @Tatsh in commit a52c908.

[viccuad]

I found it on 0.5.3, the version that is currently being shipped in Debian.

I will happily drop the patch for the next shipped version :)

Seems like we can consider this fixed, let me close the issue.
Thanks and cheers.

[suchow]

@viccuad I've released Proselint 0.6.0, which includes this change.