Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call to undefined function uv_loop_new() #14

Closed
douggr opened this issue Dec 26, 2014 · 4 comments
Closed

Call to undefined function uv_loop_new() #14

douggr opened this issue Dec 26, 2014 · 4 comments

Comments

@douggr
Copy link
Contributor

douggr commented Dec 26, 2014

Hi,

using new Amp\UvReactor() directly (instead of Amp\getReactor) doesn't
check if php-uv is loaded and then it dies with a 'Call to undefined
function' message.

What about throw a RuntimeException if php-uv is not loaded?
@staabm
Copy link
Member

staabm commented Dec 26, 2014

Sounds like a good idea.. I think we should also add "uv" to composer suggests as it is required for high performance use cases

@douggr
Copy link
Contributor Author

douggr commented Dec 29, 2014

This also applies to LibeventReactor.

@rdlowrey
Copy link
Contributor

rdlowrey commented Jan 5, 2015

Looks good ... feel free to PR these commits at your leisure.

@douggr douggr mentioned this issue Jan 6, 2015
Merged
@douggr
Copy link
Contributor Author

douggr commented Jan 17, 2015

#16

@douggr douggr closed this as completed Jan 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@douggr @staabm @rdlowrey