Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Amp\ByteStream\splitLines() #109

Closed
PhantomArt opened this issue Feb 17, 2024 · 0 comments
Closed

Error in Amp\ByteStream\splitLines() #109

PhantomArt opened this issue Feb 17, 2024 · 0 comments

Comments

@PhantomArt
Copy link

$cancellation is not passed to split(). Apparently, this is not how it should be.

/**
 * Splits the stream into lines.
 *
 * @return \Traversable<int, string>
 */
function splitLines(ReadableStream $source, ?Cancellation $cancellation = null): \Traversable
{
    foreach (split($source, "\n") as $line) {
        yield \rtrim($line, "\r");
    }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant