Can cause infinite loop in caller code

[Ekstazi]

byte-stream/lib/ResourceInputStream.php

Line 121 in 22113f2

return new Success; // Resolve with null on closed stream.

In some rare cases if caller code doesn't check for null this may cause infinite loop and amp loop will not work.

Need to use immediateWatcher instead. This may also affects output stream.

Also see related ticket:
amphp/ssh#16

[kelunik]

I think an infinite loop here is better, because it makes you aware of that coding error. Using an immediate watcher just hides the problem.

[kelunik]

I don't think we can do anything here to improve the situation without breaking the interface. I think the best thing to do would be throwing an exception if read() is called repeatedly and returned null before.