Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to connect code is bogus #4

Closed
Danack opened this issue Dec 27, 2014 · 1 comment
Closed

Fail to connect code is bogus #4

Danack opened this issue Dec 27, 2014 · 1 comment

Comments

@Danack
Copy link
Contributor

Danack commented Dec 27, 2014

The code here seems quite wrong.

It's not checking that $socket is not null, and so I'm getting the error fclose() expects parameter 1 to be resource, null given in ...amp-mysql/lib/Connection.php on line 138.

Also, I think it should be checking for the error first and calling the $future->fail regardless of connection state.

@bwoebi
Copy link
Member

bwoebi commented Dec 28, 2014

I hope it is fixed now, it shouldn't loop authentications anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants