[TACHYON-1534] Fix flaky tachyon.shell.TfsShellTest#lsTest #2474
Conversation
| MasterContext.getConf().set(Constants.SECURITY_GROUP_MAPPING, | ||
| IdentityUserGroupsMapping.class.getName()); | ||
|
|
||
| FileInfo[] files = new FileInfo[4]; | ||
| String testUser = "test_user_lsr"; | ||
| System.setProperty(Constants.SECURITY_LOGIN_USERNAME, testUser); | ||
| // clear the loginUser and re-login with new user |
There was a problem hiding this comment.
Thank @dongche for the fix, a minor comment is we can move user login to a private method.
There was a problem hiding this comment.
Sounds good. Thanks
|
Test PASSed. |
|
@sundapeng thanks for your review. Updated the patch to move them to a private method. |
|
Test FAILed. |
|
Test PASSed. |
Conflicts: integration-tests/src/test/java/tachyon/shell/TfsShellTest.java
|
LGTM, thanks for the fix! |
|
+1 LGTM |
[TACHYON-1534] Fix flaky tachyon.shell.TfsShellTest#lsTest
|
Because of this,my test failed several times.Thanks for your fix.@sundapeng |
JIRA: https://tachyon.atlassian.net/browse/TACHYON-1534
Fix flaky tachyon.shell.TfsShellTest#lsTest. The clean and re-login is not a atomic operation, so that the re-login user sometimes is not expected. This patch put them into a synchronized block.
@apc999 , @sundapeng , would you like to take a look at this?