Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐️ Plugin: Opentelemetry #1068

Closed
yuval-hazaz opened this issue Dec 29, 2020 · 3 comments · Fixed by amplication/plugins#163
Closed

⭐️ Plugin: Opentelemetry #1068

yuval-hazaz opened this issue Dec 29, 2020 · 3 comments · Fixed by amplication/plugins#163

Comments

@yuval-hazaz
Copy link
Member

yuval-hazaz commented Dec 29, 2020

Add support for https://opentelemetry.io/

This plugin will leverage the amplication maintained package @amplication/opentelemetry-nestjs .

Acceptance criteria:

  • The generated code will contain the docker-compose service for jaeger
  • The generated code will use BatchSpanProcessor and OTLPTraceExporter from @opentelemetry/exporter-trace-otlp-grpc to export traces to jaeger
  • The generated code will configure the OpenTelemetryModule with serviceName from the amplication service name
  • The settings will allow user to define:
    • exporter url that amplication will use to configure an environment variable named: OTEL_EXPORTER_OTLP_ENDPOINT. i.e.
    OTEL_EXPORTER_OTLP_ENDPOINT: "http://localhost:4317"
    
    • optional configurable service name

Tech notes

An example of a working solution is available here: https://github.com/overbit/otel-workshop

Icon:
opentelemetry

@yuval-hazaz
Copy link
Member Author

should be implemented as a plugin

@GreenMachine01 GreenMachine01 changed the title Server: opentelemetry ⭐️ Plugin: Opentelemetry Sep 29, 2022
@GreenMachine01 GreenMachine01 removed this from the v0.3 milestone Dec 19, 2022
@overbit
Copy link
Contributor

overbit commented Mar 23, 2023

@yuval-hazaz is this for generated code, correct?
We will need one issue for our services

@Shurtu-gal
Copy link
Collaborator

@overbit Can I be assigned to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants