Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Bug Report: width of the create repository popup is changing when error is shown #2385

Closed
amitbarletz opened this issue Mar 8, 2022 · 2 comments 路 Fixed by #2448
Closed

馃悰 Bug Report: width of the create repository popup is changing when error is shown #2385

amitbarletz opened this issue Mar 8, 2022 · 2 comments 路 Fixed by #2448
Assignees
@jainpawan21
Labels
type: bug Something isn't working
Milestone
0.12.2

Comments

@amitbarletz
Copy link

amitbarletz commented Mar 8, 2022 •
edited by yuval-hazaz

What happened?

After choosing an organization and clicking on create new repository button, type one letter and move the focus outside of the textbox - an error message will show, and the width of the popup is changed.

image

image

What you expected to happen

The width of the popup should be stable

How to reproduce

click on github icon on the left side
chose your organization
click on new repository button
type 1 letter and click on Tab
observe the change in the width

Amplication version

12.0.0

Environment

node version 14.17.0
npm version 7.3.0
macOS

Are you willing to submit PR?

No response
@amitbarletz amitbarletz added the type: bug Something isn't working label Mar 8, 2022
@souravjain540 souravjain540 self-assigned this Mar 9, 2022
@yuval-hazaz yuval-hazaz changed the title 馃悰 Bug Report: width of the create repository popup is changing on the first keystroke 馃悰 Bug Report: width of the create repository popup is changing when error is shown Mar 14, 2022
@souravjain540 souravjain540 mentioned this issue Mar 15, 2022
Closed
@jainpawan21
Copy link
Contributor

jainpawan21 commented Mar 16, 2022 •
edited

Hi @souravjain540 and @yuval-hazaz
I would like to work on this.
Can you please assign this to me?

@souravjain540
Copy link
Contributor

souravjain540 commented Mar 16, 2022 •
edited

sure @jainpawan21. have a good time coding it.

@jainpawan21 jainpawan21 mentioned this issue Mar 16, 2022
Merged
2 tasks
@mshidlov mshidlov linked a pull request Mar 21, 2022 that will close this issue
fix: width fix when error shown in git create repo #2448
Merged
2 tasks
@mshidlov mshidlov added this to the 0.12.2 milestone Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jainpawan21 jainpawan21

Labels
type: bug Something isn't working
Projects
None yet
Milestone
0.12.2
Development

Successfully merging a pull request may close this issue.

fix: width fix when error shown in git create repo jainpawan21/amplication
4 participants
@jainpawan21 @souravjain540 @mshidlov @amitbarletz