Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug Report: as a user I want to see a loader animation on the code view page when I expand a folder #7054

Open
yuval-hazaz opened this issue Sep 15, 2023 · 9 comments · May be fixed by #7330
Open

🐛 Bug Report: as a user I want to see a loader animation on the code view page when I expand a folder #7054

yuval-hazaz opened this issue Sep 15, 2023 · 9 comments · May be fixed by #7330
Assignees
@VishalPraneeth
Labels
epic: UX/UI impact: User Experience initiatives that focus on improving the overall user experience open to community

Comments

@yuval-hazaz
Copy link
Member

What happened?

When a user expands the folders, there is no indication that the files of the folder are loading

What you expected to happen

When a user expands a folder and while the client waits for the data from the server, the user should see a loader animation

How to reproduce

go to code view and expands a folder

Amplication version

1.8.11

Environment

No response

Are you willing to submit PR?

No response
@souravjain540 souravjain540 transferred this issue from amplication/hacktoberfest-issues Sep 29, 2023
@ptdatta
Copy link

ptdatta commented Sep 30, 2023

@yuval-hazaz @souravjain540 I want to work on it. Please assign it to me.

@LunarMarathon
Copy link

Please re-assign this to me in case of inactivity. Thank you

@aeswibon
Copy link

aeswibon commented Oct 2, 2023

I'd love to work on this issue! Please consider assigning this issue to me.

@GreenMachine01 GreenMachine01 added impact: User Experience initiatives that focus on improving the overall user experience epic: UX/UI labels Oct 3, 2023
@yuval-hazaz
Copy link
Member Author

Note to anyone who takes this - I had the chance to play with it a little bit in the past, and I have this initial code that may help anyone who takes it.
The change is based on the fact that there may be multiple request for multiple nodes at the same time, and we need to make sure we show the loader for each node, and we also know how to replace the content of the correct node when the results are returned.
It is still not 100% functional but it can be used as a base for the solution.

If you think you have a different approach you want to try - feel free to do it

Image

@CoderGhost37
Copy link

@yuval-hazaz can I do it?
Please assign it to me

@souravjain540
Copy link
Contributor

@CoderGhost37 would love to hear your approach. :)

@Prashant04627
Copy link

what do you mean by expanding a folder @yuval-hazaz

@VishalPraneeth
Copy link
Contributor

@souravjain540 , Can you assign it please, I'd try to fix this

@yuval-hazaz
Copy link
Member Author

@VishalPraneeth you are assigned, good luck

@VishalPraneeth VishalPraneeth linked a pull request Oct 26, 2023 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VishalPraneeth VishalPraneeth

Labels
epic: UX/UI impact: User Experience initiatives that focus on improving the overall user experience open to community
Projects
⭐️ Community Issues ⭐️
Status: Open for Community
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/7054 load expand folder VishalPraneeth/amplication
9 participants
@yuval-hazaz @souravjain540 @aeswibon @CoderGhost37 @ptdatta @VishalPraneeth @GreenMachine01 @LunarMarathon @Prashant04627