Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate code per service #8500

Open
PazYanoverr opened this issue May 16, 2024 · 4 comments · Fixed by #8684
Open

Generate code per service #8500

PazYanoverr opened this issue May 16, 2024 · 4 comments · Fixed by #8684

Comments

@PazYanoverr
Copy link
Member

PazYanoverr commented May 16, 2024

General: We would like to have the following build / code generation options:

  1. Generate code for all services
  2. Generate code for all services that have pending changes
  3. Generate code for a specific service

Detailed request:

  1. When pressing the "Generate the code" option- the code will be generated for all the services
  2. The "Generate the code" will also have an "arrow" option that will open a menu with the following options:
    a. Generate the code for all services
    b. Generate the code for services with changes
    c. Generate the code for service [name]
    d. Generate the code for service [name]
  3. In case the user chooses option c- and there are pending changes for other services, a message should appear saying-
    "Note: There are pending changes for other services as well.
    Generating the code for service '[name]' will update all services with their changes, but only the code for the chosen service will be generated."
    Buttons: Cancel, Generate
  4. We need to modify the commit event to include the chosen type of commit out of the options above (add new metadata to the existing event) - preferably on the server side event
@abrl91
Copy link
Contributor

abrl91 commented Jun 3, 2024

@PazYanoverr
what about having an icon to "generate code" on each service (like the delete button)
It can be disabled if there are no pending changes.

image

@PazYanoverr
Copy link
Member Author

@abrl91 - It's a good idea! The only problem with it, is that when generating the code for service A, the pending changes and other changes (DSG-originated and such) will be applied for other services as well. I am afraid it's a little bit confusing, so I think we should try to avoid this path in a prominent location.
WDYT?

@abrl91 abrl91 linked a pull request Jun 17, 2024 that will close this issue
2 tasks
@mulygottlieb
Copy link
Member

Requires completing the client side

@mulygottlieb
Copy link
Member

@PazYanoverr I am moving this back to "todo" for the client side (server is done)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants