Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dsg): validate min and max #8688

Merged
merged 4 commits into from
Jun 20, 2024
Merged

fix(dsg): validate min and max #8688

merged 4 commits into from
Jun 20, 2024

Conversation

abrl91
Copy link
Contributor

@abrl91 abrl91 commented Jun 17, 2024

Close: https://github.com/amplication/private-issues/issues/169

PR Details

PR Checklist

  • Tests for the changes have been added
  • npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

nx-cloud bot commented Jun 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e553bc1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@abrl91 abrl91 marked this pull request as ready for review June 18, 2024 08:38
@abrl91 abrl91 requested a review from mulygottlieb June 18, 2024 08:38
@mulygottlieb mulygottlieb merged commit 11b4dac into next Jun 20, 2024
11 checks passed
@mulygottlieb mulygottlieb deleted the fix/validate-minmax branch June 20, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants