fix: Handle exceptions raised by request.urlopen in HttpClient.post
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohan-amplitude
suggested changes
Apr 21, 2022
|
@Sija Thank you for helping us and fix the bug here. I'm working on adding more test case and find/fix potential bugs. |
bohan-amplitude
approved these changes
Apr 21, 2022
|
@bohan-amplitude Could this be released as a bugfix release anytime soon? I'm asking since this prevents us from using this library at the moment. |
|
@Sija Just released this to PyPi. Version 0.2.1 should be available now. |
|
@bohan-amplitude Great, thanks! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At the moment the sad path is essentially non-functional, as
request.urlopenraisesHTTPErrorexceptions for responses with status code 400...500. This PR fixes buggy exception handling inHttpClient.postfunction making it work as expected.Checklist