Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix broken release action #24

Merged
merged 1 commit into from
May 11, 2022

Conversation

bohan-amplitude
Copy link
Contributor

Summary

fix release github aciton

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@kevinpagtakhan
Copy link

How is status quo broken and how are the changes fixing the issue?

@bohan-amplitude
Copy link
Contributor Author

bohan-amplitude commented May 11, 2022

How is status quo broken and how are the changes fixing the issue?

The dry-run using semantic-release command success but the relekang/python-semantic-release@master action failed with some debug info seems like can not get new version number. It works fine before. I changed to use semantic-release command and tested successfully.

@kevinpagtakhan
Copy link

kevinpagtakhan commented May 11, 2022

Have we considered pinning to a version instead of master so we get consistent behavior?

EDIT: I mean pinning the version for relekang/python-semantic-release

@bohan-amplitude
Copy link
Contributor Author

Have we considered pinning to a version instead of master so we get consistent behavior?

EDIT: I mean pinning the version for relekang/python-semantic-release

I don't know what version they have, the only branch of the repo is master and the doc gives example to use @master.
This action is a wrapper of semantic-release command from python-semantic-release package. It also has other problems like can't set commit user and email and use actions-bot by default. Command is more configurable and read config file pyproject.toml from the project repo, could be a better choice.

@kevinpagtakhan
Copy link

Gotcha, if we generally prefer the new approach then this should be fine.

@bohan-amplitude bohan-amplitude merged commit 8eb6e52 into amplitude:main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants