Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set correct fetch-depth for semantic release #25

Merged
merged 1 commit into from
May 12, 2022

Conversation

bohan-amplitude
Copy link
Contributor

Summary

set fetch-depth to 0 for checkout action

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

Copy link

@kevinpagtakhan kevinpagtakhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this to fetch the tags to determine the new correct version to bump to?

Copy link
Contributor

@qingzhuozhen qingzhuozhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for checkout action. Set fetch-depth: 0 means to fetch all history for all branches and tags

@kevinpagtakhan
Copy link

This is for checkout action. Set fetch-depth: 0 means to fetch all history for all branches and tags

what are we trying to achieve by fetching all branches and tags? just wanted to make sure the PR has enough context on what the issue it's trying to solve

@bohan-amplitude
Copy link
Contributor Author

is this to fetch the tags to determine the new correct version to bump to?

Yes, semantic release need whole commit history to get new version. Otherwise it can only see the last commit.

@bohan-amplitude bohan-amplitude merged commit 0514d40 into amplitude:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants