Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set group should set user property #51

Merged
merged 1 commit into from
Sep 1, 2023
Merged

fix: set group should set user property #51

merged 1 commit into from
Sep 1, 2023

Conversation

Mercy811
Copy link
Contributor

@Mercy811 Mercy811 commented Sep 1, 2023

Summary

https://amplitude.atlassian.net/browse/AMP-83718

set_group() should set both event.groups and event.user_properties.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@Mercy811 Mercy811 merged commit 964a1b6 into main Sep 1, 2023
8 checks passed
@Mercy811 Mercy811 deleted the AMP-83718-fix-setGroup branch September 1, 2023 20:59
justin-fiedler
justin-fiedler reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mercy811!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-fiedler justin-fiedler justin-fiedler left review comments

@yuhao900914 yuhao900914 yuhao900914 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mercy811 @justin-fiedler @yuhao900914