Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add privacy manifest for ios 17 #109

Merged
merged 4 commits into from
Jan 23, 2024
Merged

feat: add privacy manifest for ios 17 #109

merged 4 commits into from
Jan 23, 2024

Conversation

Mercy811
Copy link
Collaborator

@Mercy811 Mercy811 commented Jan 20, 2024

Summary

https://amplitude.atlassian.net/browse/AMP-78469

iOS 17 requires this privacy manifest to list all data fields tracked. This PR only includes fields that are tracked by default. Customers should add more fields to their app's privacy manifest file if they decide to track more fields using Amplitude SDK. For example, by default the SDK tracks device Id only, but users can track user Id as well by amplitude.setUserId(). To do so, they have to add "User ID" NSPrivacyCollectedDataTypeUserID to NSPrivacyCollectedDataType.

Please note that the definition of tracking is

Tracking refers to the act of linking user or device data collected from your app with user or device data collected from other companies' apps, websites, or offline properties for targeted advertising or advertising measurement purposes
So NSPrivacyTracking is not set and NSPrivacyCollectedDataTypeTracking should be false

Fields

Data type Linked to User Used for tracking’ Reason for collection
Product interaction No No Analytics
Device ID Yes No Analytics
Precise Location No Yes Analytics

Domain

https://api2.amplitude.com/2/httpapi

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@Mercy811 Mercy811 marked this pull request as ready for review January 20, 2024 01:29
@Mercy811 Mercy811 requested a review from izaaz January 22, 2024 20:17
Copy link
Collaborator

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Can you please add some documentation that helps users add additional fields as needed. Thanks!

users can track user Id as well by amplitude.setUserId(). To do so, they have to add "User ID" NSPrivacyCollectedDataTypeUserID to NSPrivacyCollectedDataType.

@Mercy811
Copy link
Collaborator Author

I think this looks good. Can you please add some documentation that helps users add additional fields as needed. Thanks!

users can track user Id as well by amplitude.setUserId(). To do so, they have to add "User ID"

Thanks @justin-fiedler for reviewing. I have another ticket for docs.

@Mercy811 Mercy811 merged commit cf0ca47 into main Jan 23, 2024
5 checks passed
@Mercy811 Mercy811 deleted the privacy-manifest branch January 23, 2024 16:53
github-actions bot pushed a commit that referenced this pull request Feb 5, 2024
# [1.2.0](v1.1.0...v1.2.0) (2024-02-05)

### Bug Fixes

* ensure event data is sandboxed per app for all platforms ([#113](#113)) ([72da9f8](72da9f8))
* should track coarse location by default ([#110](#110)) ([2aab265](2aab265))

### Features

* add privacy manifest for ios 17 ([#109](#109)) ([cf0ca47](cf0ca47))
Copy link

github-actions bot commented Feb 5, 2024

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wlxo0401
Copy link

@Mercy811

I think this is just adding 'PrivacyInfo'.

Shouldn't it be applied to SPM and CocoaPod too??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants