Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is TrackingOptions.forCoppaControl supposed to be a static function? #166

Closed
danielmatzke opened this issue May 19, 2024 · 1 comment
Closed
Labels
question Further information is requested

Comments

@danielmatzke
Copy link

The function TrackingOptions.forCoppaControl does not access the self object. It might be misleading since it looks like the function returns a COPPA-compliant version of the options it is being called on. I suggest either using the object the function is called on, or turning it into a static function.

func forCoppaControl() -> TrackingOptions {
let trackingOptions = TrackingOptions()
for property in COPPA_CONTROL_PROPERTIES {
trackingOptions.disableTrackingField(field: property)
}
return trackingOptions
}

@danielmatzke danielmatzke added the question Further information is requested label May 19, 2024
@crleona
Copy link
Collaborator

crleona commented May 20, 2024

Hi @danielmatzke, I agree this works better as a static function and is updated in #168, but please note this is not a public function and will be controlled through Configuration.enableCoppaControl

@crleona crleona closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants