feat: add privacy manifest for iOS 17 #476
Conversation
Mercy811
force-pushed
the
AMP-92243-add-privacy-manifest
branch
from
0195b53
to
73e1c05
Compare
| </array> | ||
| <key>NSPrivacyTrackingDomains</key> | ||
| <array> | ||
| <string>https://api2.amplitude.com/</string> |
There was a problem hiding this comment.
maybe worth add api.amplitude.com as well, alternative for api2.amplitude.com
There was a problem hiding this comment.
I didn't see where it is used in the SDK. Could you give the link of it
There was a problem hiding this comment.
That's the default in JS https://github.com/amplitude/Amplitude-JavaScript/blob/main/src/constants.js#L8, and could be supported in iOS as well
There was a problem hiding this comment.
This API is not in iOS SDK directly. So if customers are going to use this or other endpoints they want they have to add it by themselves. This manifest is just a reference on which endpoints can be used by the SDK by default (https://api2.amplitude.com/) or by some configurations changes (https://api.eu.amplitude.com).
There was a problem hiding this comment.
Close and merge this PR but we can add it later if it's needed.
|
🎉 This PR is included in version 8.18.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
I think this is just adding 'PrivacyInfo'. Shouldn't it be applied to SPM and CocoaPod too?? |
(cherry picked from commit 007e169)
Summary
Add privacy manifest file. It pretty much the same as amplitude/Amplitude-Swift#109
Checklist