fix: global-scope reference error in nodejs

[mattlubner]

Summary

Addresses #473 by augmenting GlobalScope with a preference to using globalThis, when available.

Checklist

• Does your PR title have the correct title format?
• Does your PR have a breaking change?: No

[mattlubner]

Hi there @kevinpagtakhan! 👋

This PR should resolve the issue we were experiencing with using amplitude-js within a Next.js project. Please let me know if there are any issues with this approach (such as breaking support for IE).

[kevinpagtakhan]

@mattlubner Thanks for working on this! We appreciate your contributions and thoughts on this matter.

I intentionally created an abstraction for the global object through the global-scope module, and would prefer to keep it. We also want to keep the solution lightweight and the SDK to support IE.

That said, what are your thoughts on updating GlobalScope to:

const GlobalScope = typeof window !== 'undefined' ? window : typeof self !== 'undefined' ? self : undefined;

I believe that should still cover the environments we want: browser, web worker, and node specifically for server side rendering.

[mattlubner]

Hey @kevinpagtakhan, no problem, I'm always happy to contribute. 🙂

I think your approach is reasonable. Although I do wonder if assigning undefined to GlobalScope in Node.js is a potential foot-gun? It might be difficult for devs to spot all possible scenarios that could trigger an accidental call to amplitude.init() when server-rendering. If they miss any, it's more likely to crash their Node.js server.

What do you think of a hybrid approach like this?

/* global globalThis */
const GlobalScope = (() => {
  if (typeof globalThis !== 'undefined') {
    return globalThis;
  }
  if (typeof window !== 'undefined') {
    return window;
  }
  if (typeof self !== 'undefined') {
    return self;
  }
  if (typeof global !== 'undefined') {
    return global;
  }
})();

export default GlobalScope;

It would be nice if there were a single library for both node and browsers, but I digress…

[kevinpagtakhan]

@mattlubner Awesome, I like your suggestion above. I feel good about the changes but I'll do some quick testing from my end, the ones I used for the web worker PR. Once that is green, I'll get this merged. Thanks again!

[github-actions]

🎉 This PR is included in version 8.14.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• v8.14.1
• GitHub release

Your semantic-release bot 📦🚀