Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several security vulnerabilities seen in amp-github-apps repo #270

Closed
rsimha opened this issue Jul 22, 2019 · 8 comments · Fixed by #591
Closed

Several security vulnerabilities seen in amp-github-apps repo #270

rsimha opened this issue Jul 22, 2019 · 8 comments · Fixed by #591

Comments

@rsimha
Copy link
Contributor

rsimha commented Jul 22, 2019

We should enable renovate for upgrade the packages in this repo to fix these and future security vulnerabilities.

image

image

@rsimha rsimha self-assigned this Jul 22, 2019
@rsimha
Copy link
Contributor Author

rsimha commented Jul 22, 2019

@danielrozenberg
Copy link
Member

renovate-bot is already on for this repo, and all renovate-bot PRs that I haven't approved are assigned to @estherkim, @erwinmombay, and @rcebulko

@rsimha
Copy link
Contributor Author

rsimha commented Jul 22, 2019

The purpose of this issue is to track the fixing of security vulnerabilities. I've edited the description. Reopening until the alerts are gone.

@rcebulko
Copy link
Contributor

Is there a way for us to see open vulnerabilities, or only repo admins/owners?

@rsimha
Copy link
Contributor Author

rsimha commented Aug 13, 2019

@rcebulko You should have access once you become a part of @ampproject/wg-infra. Let's chat offline about how we can make that happen.

Edit: You've been invited.

@rcebulko
Copy link
Contributor

/cc @rsimha

@rsimha
Copy link
Contributor Author

rsimha commented Oct 29, 2019

Curious: For all the packages that you manually upgraded, were there renovate PRs that we couldn't merge for some reason or the other?

@rcebulko
Copy link
Contributor

There had been a renovate PR for a while for Probot, but it broke owners, so I finally got to the bottom of that and fixed it. Jest, I don't recall seeing a renovate PR, and there was nothing pending. According to npm outdated, test-status was fine; it was just that set-value was a transitive dependency of a few direct dependencies that hadn't yet upgraded themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants