Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[owners] Post-approval comments seen as rejecting reviews #478

Closed
dreamofabear opened this issue Sep 26, 2019 · 1 comment · Fixed by #477
Closed

[owners] Post-approval comments seen as rejecting reviews #478

dreamofabear opened this issue Sep 26, 2019 · 1 comment · Fixed by #477
Assignees

Comments

@dreamofabear
Copy link

I noticed that ampproject/amphtml#24730 state "needs approval" for a file despite the requester already having approved the PR. Might be because new commits were added?

Current Coverage
- [NEEDS APPROVAL] src/service/extensions-impl.js (requested: jridgewell)
- test/unit/test-extensions.js (choumx)

https://github.com/ampproject/amphtml/pull/24730/checks?check_run_id=236887665

@rcebulko rcebulko self-assigned this Sep 26, 2019
@rcebulko
Copy link
Contributor

This is an unforeseen side-effect of GitHub considering post-approval comments to be "reviews" (which was unfortunately not documented in the API being used, but was documented in the GraphQL API). So in this case, it saw Justin's approval, then it saw he commented afterwards, and it appeared as if he changed his review from approval to "comment". The fix for this is pending approval in #477 and should be deployed by end-of-week.

@rcebulko rcebulko changed the title [owners] Is approval sticky? [owners] Post-approval comments seen as rejecting reviews Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants