You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that ampproject/amphtml#24730 state "needs approval" for a file despite the requester already having approved the PR. Might be because new commits were added?
This is an unforeseen side-effect of GitHub considering post-approval comments to be "reviews" (which was unfortunately not documented in the API being used, but was documented in the GraphQL API). So in this case, it saw Justin's approval, then it saw he commented afterwards, and it appeared as if he changed his review from approval to "comment". The fix for this is pending approval in #477 and should be deployed by end-of-week.
I noticed that ampproject/amphtml#24730 state "needs approval" for a file despite the requester already having approved the PR. Might be because new commits were added?
https://github.com/ampproject/amphtml/pull/24730/checks?check_run_id=236887665
The text was updated successfully, but these errors were encountered: