Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP Mode Notice for Index listings #1366

Closed
2 tasks
postphotos opened this issue Aug 27, 2018 · 9 comments
Closed
2 tasks

AMP Mode Notice for Index listings #1366

postphotos opened this issue Aug 27, 2018 · 9 comments
Labels
Projects
Milestone

Comments

@postphotos
Copy link
Contributor

postphotos commented Aug 27, 2018

As a user, I should be presented with a notice that reveals what mode of AMP I’m using so I understand what each action does based on the current mode.

Without this notice, a given user may think actions take effect on their site, but when auto-sanitize mode is turned on (either by force for "Native" mode or optionally for "Paired" mode),

  • AC1: Surface a given notice based on the mode (from the settings page) in each of the views where actions can occur.
  • AC2: Propose copy (and perhaps a suggestion to turn on Auto Suppression) for Native, Paired (non-auto) and Paired (auto) modes. Also, in Paired Mode (non-auto) offer a dismissable notice to help the user turn this on to enable auto sanitization sitewide.

Notes:

  • If a user is in Paired Mode with auto-sanitize or in Native AMP mode, each error is but a notice and does not affect the site.
  • If a user is in Paired Mode without auto-sanitize, each action might affect which pages are served as AMP. A given user, by not taking action on errors, would prevent AMP from being served on those pages.
  • If a user is in Classic Mode, they should know they won't get the index listings (nor the single listings) as the sanitizer does not run in this mode.
@kienstra
Copy link
Contributor

kienstra commented Aug 27, 2018

Question About Notice

Hi @postphotos,
Thanks for opening this issue.

Did you have in mind a notice like this one (that already exists):
notice-amp

Another point:

c) If a user is in Classic Mode, they should know they won't get the index listings (nor the single listings) as the sanitizer does not run in this mode.

In Classic Mode, the validator UI generally doesn't exist, including that screenshot above.

@kienstra
Copy link
Contributor

AC1: Surface a given notice based on the mode (from the settings page) in each of the views where actions can occur.

Maybe there could also be a notice on the "AMP Validation Errors" page:

notice-template-mode

@hellofromtonya hellofromtonya added this to Definition in v1.0 Aug 27, 2018
@postphotos
Copy link
Contributor Author

Hi @kienstra, what you described here is what we have in mind for the scope of this ticket.

In short, currently a user might "accept" an error in Native AMP mode, but (lo and behold) nothing happens. Between showing an icon (i.e. the AMP lightning bolt logo) next to AMP serving URLs, and limited (perhaps dismissable? @jwold) notices on Index Pages we hope to reduce the confusion on what actions mean for index pages. Instead of the click-and-explore method, we want to give them clear notices for what they should expect. I know @jwold has a sketch that explains the possible states.

I broke apart AC2 here - We've worked on copy a bit already, but you should be unblocked to start AC1 at your leisure.

@postphotos postphotos moved this from Definition to To do in v1.0 Aug 27, 2018
@miina miina self-assigned this Aug 29, 2018
@miina
Copy link
Contributor

miina commented Aug 29, 2018

@postphotos To confirm:

  1. Would the notice be on all index pages (as of now on the Errors page and on the Invalid Pages both)?
  2. Is this the notice that the issue involves:
    screen shot 2018-08-29 at 11 30 21 am

Edit:
As of now added the following notices, let me know if you already had some texts:

  • Native mode:
    The site is using native AMP mode, the validation errors found are already automatically handled.
  • Paired mode with auto-sanitization:
    The site is using paired AMP mode with auto-sanitization turned on, the validation errors found are already automatically handled.
  • Paired mode without auto-sanitization:
    The site is using paired AMP mode without auto-sanitization, the validation errors found require action and influence which pages are shown in AMP. For automatically handling the errors turn on auto-sanitization from Validation Handling settings. (<--- link)
  • Classic mode:
    The site is using classic AMP mode, your theme templates are not used and the errors below are irrelevant.
    <--- Although the index pages are not visible when in classic mode, it is possible to see this notice when turning on Classic mode in one tab and refreshing an index page in the other tab, thus the notice.

For example:
screen shot 2018-08-29 at 12 50 35 pm

@miina miina moved this from To do to In progress in v1.0 Aug 29, 2018
@westonruter
Copy link
Member

I don't think it needs to be dismissible, does it?

@miina
Copy link
Contributor

miina commented Aug 30, 2018

True, it doesn't. Removed.

@postphotos
Copy link
Contributor Author

Hi @miina, thanks for this update. I have no issue with the given wording that's been written, and think this is the intention of this ticket. 👍 Looks good to me!

@miina miina moved this from In progress to Ready for review in v1.0 Sep 4, 2018
@hellofromtonya hellofromtonya moved this from Ready for review to Ready for QA in v1.0 Sep 6, 2018
@kienstra
Copy link
Contributor

Request For Testing

Hi Claudio,
Could you please test the notices, like the on the Invalid URLs page?

amp-notice

@kienstra kienstra assigned csossi and unassigned miina Sep 18, 2018
@csossi
Copy link

csossi commented Sep 19, 2018

Notices appearing for Invalid URLS index and Error Index

@csossi csossi removed their assignment Sep 19, 2018
@csossi csossi moved this from Ready for QA to Ready for Merging in v1.0 Sep 19, 2018
@kienstra kienstra moved this from Ready for Merging to In Production in v1.0 Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v1.0
In Production
Development

No branches or pull requests

5 participants