Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings callout for "view your site as amp" after initial save #1399

Closed
3 tasks
postphotos opened this issue Sep 5, 2018 · 10 comments
Closed
3 tasks

Settings callout for "view your site as amp" after initial save #1399

postphotos opened this issue Sep 5, 2018 · 10 comments
Assignees
Labels
Projects
Milestone

Comments

@postphotos
Copy link
Contributor

postphotos commented Sep 5, 2018

As a user on first activation of the plugin, I should have a clear call-to-action after deciding my AMP settings for my site to view my site as AMP or to debug errors.

In current form, a user completes the form on the settings page and is presented with a notice that says Settings Saved. - this intends to replace this with new copy and directions. While it's important to notify a user that the tool works as expected, a user also needs a clear throughline from activation of the plugin to engagement with the AMP version of their to understand what the point of this tool is and how it works.

As part of the work in #1006, #1288, #1359 it was clear that a new information design for the settings page was needed. By providing a strong CTA after initial save, a user should engage with the AMP site more readily.

  • AC1: Write copy that encourages a user to engage with the site given the condition. Suggestions : View the AMP version of your site! or View the Classic AMP version of your site. (We strongly recommend upgrading to Paired Mode.) or View the Native AMP version of your site.
  • AC2: Based on the outcomes of Implement settings splash notice #1381, implement the ability to surface a call-to-action that would appear after a user "saves" the settings.
  • AC3: Integrate copy from AC1 into the new CTA feature.
@westonruter
Copy link
Member

Also, there can actually be a direct line from paired/native to “View site as AMP”. If you are logged-in as an admin, which you would be on this screen, you can access your site with /?amp_validate in the URL to see it with AMP enabled, even if you are still in classic paired mode. This gives you the ability to preview your site with your own eyes before you do the switch. You don't even need to look at the validation errors.

@postphotos
Copy link
Contributor Author

Just a heads up, I've updated the initial post to write out out a full user story for this ticket.

@postphotos postphotos moved this from Definition to To do in v1.0 Sep 10, 2018
@kienstra
Copy link
Contributor

Question About Call To Action

Hi @postphotos,
Thanks for the detailed ACs here.

AC2: Based on the outcomes of #1381, implement the ability to surface a call-to-action that would appear after a user "saves" the settings.

Would this call to action be a notice, like before?

amp-version-site

@postphotos
Copy link
Contributor Author

@kienstra Yep, that's the intent! It'd be leveraging the same space as the "settings saved" screen, but it'd be important to still notify the user that the action was completed.

So with that said, in regard to AC1, I think the language should probably be something like:

  • Paired Mode activated! View your site as AMP now or Review Errors
  • Native Mode activated! View your site as AMP now or Review Errors
  • Classic Mode activated! View your site as AMP now. We recommend upgrading to Native or Paired mode.

Seeking feedback and hoping to iterate here.

@kienstra
Copy link
Contributor

Notice Copy Looks Good

Hi @postphotos,
That copy for notices looks good.

The first time someone activates Native or Paired mode, there probably won't be any errors to review. But we could add a condition to only output 'or Review Errors' when there are errors.

@postphotos
Copy link
Contributor Author

I think we can have that error.

@kienstra - I think we'd have that information available to us, if not even more.

I don't quite understand when or how the plugin checks for the initial batch of errors, but I know @westonruter talked about trying to surface the number of errors (or at least the existence of) upon initial activation. (And I'd love clarity there if either of you can help.)

For this notice in particular, I don't want to overwhelm the user, but at least drive them onward through to the error flow and compatibility tool if that should be their next steps.

Thoughts? cc: @westonruter

@kienstra
Copy link
Contributor

Reply Regarding Validation

Hi @postphotos,
Sorry for the delay in replying.

...how the plugin checks for the initial batch of errors...

There are only 2 ways I know of that this plugin validates a URL without the user explicitly doing so (like clicking 'Re-validate' in the admin bar or 'Recheck' on the 'Invalid URLs' page):

  1. On updating a post:

clicking-save-draft

  1. After activating any plugin other than this, it validates a post that is eligible for AMP:

plugin-notice-amp

Also, there is a WP-CLI script to test for validity in #1183.

@kienstra kienstra moved this from To do to In progress in v1.0 Sep 18, 2018
@kienstra kienstra moved this from In progress to Ready for QA in v1.0 Sep 24, 2018
@kienstra
Copy link
Contributor

Request For Testing

Hi @csossi,
Could you please test this?

  1. Go to the AMP Settings page
  2. Change the 'Template Mode.' For example, if it's currently 'Native,' change it to 'Paired'
  3. Expected: There's a notice that applies to that mode:

paired-save-changes

  1. Repeat step 2, but change it to 'Native' and 'Classic' modes.
  2. Expected: There is a separate message for each. The copy could change, so don't worry too much about that.

@csossi
Copy link

csossi commented Sep 26, 2018

Verified in QA

@csossi csossi moved this from Ready for QA to Ready for Merging in v1.0 Sep 26, 2018
@csossi csossi removed their assignment Sep 26, 2018
@kienstra
Copy link
Contributor

Thanks, @csossi!

@kienstra kienstra added this to the v1.0 milestone Dec 4, 2018
@kienstra kienstra moved this from Ready for Merging to In Production in v1.0 Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v1.0
In Production
Development

No branches or pull requests

4 participants