Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline Theme Selection when Reader Mode is activated #4475

Closed
6 tasks done
amedina opened this issue Mar 31, 2020 · 0 comments · Fixed by #4998
Closed
6 tasks done

Streamline Theme Selection when Reader Mode is activated #4475

amedina opened this issue Mar 31, 2020 · 0 comments · Fixed by #4998
Assignees
@amedina
Labels
Changelogged Whether the issue/PR has been added to release notes. Groomed P0 High priority RME Reader Mode Expansion UX WS:UX Work stream for UX/Front-end
Projects
Ongoing
Milestone
v2.0

Comments

@amedina
Copy link
Member

amedina commented Mar 31, 2020 •
edited by westonruter

Users selecting the Reader Mode template mode are guided through the selection of the theme to be used:

Existing users of Reader mode using legacy post templates

  • Continue using the Legacy theme as the default when they upgrade the AMP plugin.
  • Provide ability to switch from legacy post templates to full site reader mode theme.

New users or existing users enabling Reader mode

  • Choose a theme from a curated list of AMP-compatible themes when switching to Reader Mode (or already in Reader mode)
  • Not allowed to select the currently-active theme as the theme for Reader mode since such a case corresponds to setting the AMP plugin to Transitional Mode.
  • If a user changes the active theme at some point to be the same as the theme used for Reader mode, then they automatically get switched to Transitional mode.
  • Users may still select the legacy post templates, but this will be clearly marked as legacy/deprecated.
@amedina amedina added this to Backlog in Ongoing Mar 31, 2020
@amedina amedina added the RME Reader Mode Expansion label Mar 31, 2020
@amedina amedina added the P0 High priority label Apr 13, 2020
@kmyram kmyram added the WS:UX Work stream for UX/Front-end label May 15, 2020
@westonruter westonruter added this to the v1.6 milestone Jun 15, 2020
@westonruter westonruter moved this from Backlog to In Progress in Ongoing Jul 7, 2020
@johnwatkins0 johnwatkins0 mentioned this issue Jul 7, 2020
Merged
3 tasks
@johnwatkins0 johnwatkins0 moved this from In Progress to Ready for Review in Ongoing Jul 8, 2020
@westonruter westonruter mentioned this issue Jul 8, 2020
Merged
7 tasks
@westonruter westonruter moved this from Ready for Review to Ready for QA in Ongoing Jul 10, 2020
@kmyram kmyram assigned amedina and unassigned westonruter and johnwatkins0 Jul 15, 2020
@amedina amedina moved this from Ready for QA to QA Passed in Ongoing Jul 15, 2020
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amedina amedina

Labels
Changelogged Whether the issue/PR has been added to release notes. Groomed P0 High priority RME Reader Mode Expansion UX WS:UX Work stream for UX/Front-end
Projects
Ongoing
  
QA Passed
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Settings screen updates ampproject/amp-wp
4 participants
@westonruter @amedina @kmyram @johnwatkins0